Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures use AppContext instead of DatabaseConnection #1063

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DenuxPlays
Copy link
Contributor

Breaking Change!!

This is a breaking change due to changing the argument of the Hooks trait.

Refs

Needs: #1061

Closes: #1060

@DenuxPlays DenuxPlays mentioned this pull request Dec 7, 2024
@DenuxPlays DenuxPlays force-pushed the feature/fixture-use-app-context branch 8 times, most recently from 56eb26c to 4f3f2d4 Compare December 7, 2024 22:44
@DenuxPlays DenuxPlays force-pushed the feature/fixture-use-app-context branch from 4f3f2d4 to 618e325 Compare December 7, 2024 22:48
@DenuxPlays
Copy link
Contributor Author

I think the loco-new:ci is broken

It's just looping over the same 15 Tests.

@DenuxPlays
Copy link
Contributor Author

I think the loco-new:ci is broken

It's just looping over the same 15 Tests.

GitHub will kill it after 6 hours which will result in a "failure".
So nothing I can do here.

@kaplanelad
Copy link
Contributor

@DenuxPlays
Could you explain the use case? Why is it necessary to include the app context within the seed hook?

@DenuxPlays
Copy link
Contributor Author

@DenuxPlays Could you explain the use case? Why is it necessary to include the app context within the seed hook?

As described in the issue.
Ref: #1060 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seed function in Hook should get AppContext as an argument.
2 participants