Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Spectral Layout #993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sakshi-2797
Copy link

@Sakshi-2797 Sakshi-2797 commented Apr 5, 2023

This contribution includes a faster implementation of the spectral_layout function. The implementation replaces the eigenvalue compute with a faster MKL based method. The modification provides a speedup of ~9x in some cases.
Important - This modification is dependent on "libmkl_rt.so" library.

@Sakshi-2797 Sakshi-2797 force-pushed the spectral_layout branch 2 times, most recently from 8c9b0ab to a665496 Compare April 5, 2023 08:18
@lmcinnes
Copy link
Owner

lmcinnes commented Apr 5, 2023

While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.

@Sakshi-2797
Copy link
Author

While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.

Hi @lmcinnes ,
We have made the required changes , the environment variable is changed to a dynamic implementation which will work on the on Linux and non-Linux machines. However , we are facing some issues while raising a PR as some pre commit tests aren't passing. Is there a way to run these tests on local environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants