Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Eigensolver's init and method arguments in UMAP class #1143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

duguyue100
Copy link

@duguyue100 duguyue100 commented Jul 24, 2024

Changing init and method in the _spectral_layout function can sometimes make a big performance difference. However, since UMAP doesn't expose these parameters, it's almost impossible to change them without copying a local copy and changing the code. Here I exposed them in the UMAP class.

FYI

  • I didn't touch the AlignUMAP and Parametric UMAP objects. We could update them if the reviewers see this is a viable option.
  • My doc formatter slightly changed some docstring lines, hopefully this is fine.

@pep8speaks
Copy link

pep8speaks commented Jul 24, 2024

Hello @duguyue100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 735:53: E203 whitespace before ':'
Line 738:45: E203 whitespace before ':'

Comment last updated at 2024-07-25 08:16:37 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants