Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit tests failing with STABLEHLO disabled #3816

Open
dbabokin opened this issue Oct 24, 2024 · 1 comment
Open

Lit tests failing with STABLEHLO disabled #3816

dbabokin opened this issue Oct 24, 2024 · 1 comment
Assignees

Comments

@dbabokin
Copy link
Contributor

dbabokin commented Oct 24, 2024

When building with -DTORCH_MLIR_ENABLE_STABLEHLO=OFF and running lit tests, I see three fails:

  TORCH_MLIR :: Conversion/TorchToLinalg/sparse.mlir
  TORCH_MLIR :: Dialect/Torch/invalid.mlir
  TORCH_MLIR :: Dialect/Torch/ops.mlir

All of the fails are due to #sparse_tensor.encoding not being recogined:

bin/torch-mlir-opt < ../test/Conversion/TorchToLinalg/sparse.mlir -split-input-file -verify-diagnostics
module {
}

// -----
within split at <stdin>:3 offset :3:23: error: unexpected error: #"sparse_tensor"<"encoding<{ map = (d0, d1) -> (d0 : dense, d1 : compressed) }>"> : 'none' attribute created with unregistered dialect. If this is intended, please call allowUnregisteredDialects() on the MLIRContext, or use -allow-unregistered-dialect with the MLIR opt tool used
#CSR = #sparse_tensor.encoding<{ map = (d0, d1) -> (d0 : dense, d1 : compressed) }>
                      ^

#sparse_tensor.encoding was introduced in #2809 and #2799 by @aartbik.

The patches have nothing specific to STABLEHLO. I'm wondering if ifdefs for STABLEHLO covering too much code somewhere else.

@aartbik aartbik self-assigned this Nov 1, 2024
@aartbik
Copy link
Contributor

aartbik commented Nov 1, 2024

Due to a career switch, there will be a bit of a delay, but I will have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants