Update dependencies, test on GitHub Actions #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodaFi / @harlanhaskins ; any plans to merge this so that this |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
SwiftPM dependency is removed and
swift-tools-support-corepackage is used instead. A minor change toSystemErrorwas added to make it build.I've also added a GitHub Actions workflow to test on macOS, Ubuntu, and Windows, since Travis seems to be no longer the best place for CI.
Resolves: Issue #8
Why merge this pull request?
This allows using Lite with recent versions of Xcode.
What's worth discussing about this pull request?
Do you think that transitioning to GitHub Actions is the best approach here?
What downsides are there to merging this pull request?
The existing Travis build configuration will be abandoned.