Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge patches from Gentoo #16

Open
jonasstein opened this issue Dec 23, 2017 · 5 comments
Open

merge patches from Gentoo #16

jonasstein opened this issue Dec 23, 2017 · 5 comments

Comments

@jonasstein
Copy link

Hi,
I just saw that we have some patches on Gentoo Linux, which are not yet merged upstream.
https://github.com/gentoo/gentoo/tree/master/sys-devel/dev86/files
They fix for example a bug with clang.
https://bugs.gentoo.org/show_bug.cgi?id=523096

@mfld-fr
Copy link

mfld-fr commented Dec 25, 2017

Hello @jonasstein, thanks for the patch report. Indeed, @lkundrak looks like to be now inactive on this dev86 mainstream. Could you please tell us why you need such patches ? We could consider merging them in @jbruchon fork.

@jonasstein
Copy link
Author

@mfld-fr I am not the maintainer of the package, nor did I write the patches. So I know only what is written there in the commit logs/comments. One enables compilation with clang for example.

@mfld-fr
Copy link

mfld-fr commented Dec 26, 2017

@jonasstein : I understand, but I am afraid you did not respond to the question : is it worth to merge these patches, i.e. do you actually need them ?

@jonasstein
Copy link
Author

@mfld-fr For our Gentoo users we distribute the source together with the patches and compile the software on the users machine. So it is not urgent for Gentoo users. But I think especially the very simple clang fix could be interesting for everybody, since clang gets more and more important and more strict towards some code mistakes.

@mfld-fr
Copy link

mfld-fr commented Dec 27, 2017

@jonasstein : By "our users", should I understand you are a member of the Gentoo team ? Actually the patch for clang has already been submitted in PR #14, and merged in @jbruchon fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants