Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lx-valid </3 browserify #19

Open
Dachaz opened this issue Mar 7, 2017 · 0 comments
Open

lx-valid </3 browserify #19

Dachaz opened this issue Mar 7, 2017 · 0 comments
Assignees

Comments

@Dachaz
Copy link

Dachaz commented Mar 7, 2017

Hi there,

We were using revalidator for a few years to validate both on the backend and on the frontend side, but we finally ran into the same issue as you did in #17. After googling and finding your solution, I decided to migrate our codebase to lx-valid, especially due to your better handling of unknown properties.

While backend migration was smooth, frontend part was completely broken due to assumptions in https://github.com/litixsoft/lx-valid/blob/v1.2.4/lib/lx-valid.js#L513-L515 and https://github.com/litixsoft/lx-valid/blob/v1.2.4/lib/revalidator.js#L800. Namely, we use browserify to bundle everything together and as such the given lines just return empty references, breaking the functionality completely.

In order to benefit from your bugfix and the time invested in making sure all of our backend works with lx-valid, we're now running a locally-patched version without these window checks (just requiring the necessary libs as you would in any other node module); but this is not a decent long-term solution.

Could you guys please look into this and make it such that package managers can bundle lx-valid properly, yet that you expose the additional window logic somehow separately (e.g. only in the CDN build, or such)?

Thanks in advance!

@4kochi 4kochi self-assigned this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants