Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for auth token authentication for trusted calls #3192

Merged

Conversation

silva-fj
Copy link
Contributor

@silva-fj silva-fj commented Dec 6, 2024

As topic, this PR adds a new trusted call to request auth token that can be used with TCAuthentication.
This new authentication mechanism will allow users to make multiple requests (intents) without having to re-authenticate. The token have a block number expiration (This is the initial version, it is flexible enough to extend it to support other ways of expiration as well as add control on what can be done with the token).

Copy link

linear bot commented Dec 6, 2024

@silva-fj silva-fj requested review from kziemianek, Kailai-Wang and a team December 9, 2024 17:40
@silva-fj silva-fj marked this pull request as ready for review December 9, 2024 17:41
@BillyWooo BillyWooo added the C1-noteworthy Non-breaking change but is worth noticing for client label Dec 18, 2024
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me. If we can provider some ci test case, that would be even better.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@silva-fj
Copy link
Contributor Author

LGTM to me. If we can provider some ci test case, that would be even better.

I'll create an issue to add some integration tests 👍🏼

@silva-fj silva-fj enabled auto-merge (squash) December 20, 2024 16:29
@silva-fj silva-fj merged commit 5c1a358 into dev Dec 20, 2024
21 of 22 checks passed
@silva-fj silva-fj deleted the p-1202-create-a-new-trustedcall-to-request-authorisation-token branch December 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-noteworthy Non-breaking change but is worth noticing for client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants