-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for auth token authentication for trusted calls #3192
Adding support for auth token authentication for trusted calls #3192
Conversation
…ustedcall-to-request-authorisation-token
…ustedcall-to-request-authorisation-token
…thorisation-token
…thorisation-token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me. If we can provider some ci test case, that would be even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…thorisation-token
I'll create an issue to add some integration tests 👍🏼 |
As topic, this PR adds a new trusted call to request auth token that can be used with
TCAuthentication
.This new authentication mechanism will allow users to make multiple requests (intents) without having to re-authenticate. The token have a block number expiration (This is the initial version, it is flexible enough to extend it to support other ways of expiration as well as add control on what can be done with the token).