polls: add new django setting to enable or disable the unregistered poll #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voting - add missing changelog
goapunk
force-pushed
the
jd-2024-11-add-poll-dashboard-setting
branch
from
d77d98e to
0aefe90
Compare
hom3mad3
reviewed
Nov 12, 2024
| {props.enableUnregisteredUsers && | ||
| <div> | ||
| <label htmlFor="allowUnregisteredUsersCheckbox">Allow unregistered user to vote</label> | ||
| <input type="checkbox" id="allowUnregisteredUsersCheckbox" onChange={() => setAllowUnregisteredUsers((state) => !state)} checked={allowUnregisteredUsers} /> |
There was a problem hiding this comment.
we could use a couple more attributes:
aria-checked={allowUnregisteredUsers} // Adds an ARIA attribute for screen readers
aria-label="Toggle allowing unregistered users to vote"
There was a problem hiding this comment.
@hom3mad3 are you ok with us collecting these things for the ui refactor story for now instead of fixing them as part of this issue ?
There was a problem hiding this comment.
yes, because now with the new backend changes we keep making the code worse. could you guys maybe make a list of stuff you encounter?
hom3mad3
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voting
required to e.g. disable it in meinBerlin for now (or other forks of a+)
Tasks