Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated ckeditor fields #1689

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Nov 7, 2024

Bit of an old PR but ideally we get rid of the old ckeditor4 package. I replaced all the ckeditor4 fields in the migrations so we can remove the package, the ckeditor4 field extends CharField so it should be fine

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested a review from m4ra December 9, 2024 15:39
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m4ra m4ra merged commit 2143378 into main Dec 9, 2024
3 of 5 checks passed
@m4ra m4ra deleted the jd-2024-10-remove-old-ckeditor-fields branch December 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants