Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactors apps/debate and renames image fixtures #2527

Merged
merged 2 commits into from
Oct 2, 2023
Merged

refactors apps/debate and renames image fixtures #2527

merged 2 commits into from
Oct 2, 2023

Conversation

hklarner
Copy link
Contributor

The intention of this refactor is to

  • rename the image fixtures to adhere to Python naming conventions (camel case)
  • simplify the property last_three_creators by filtering the query directly

@hklarner hklarner requested review from goapunk and m4ra September 18, 2023 16:46
@hklarner hklarner force-pushed the hk-2023-09-refactors-debate-and-image-fixtures branch from a4650b8 to dfac03a Compare September 28, 2023 12:50
@hklarner hklarner force-pushed the hk-2023-09-refactors-debate-and-image-fixtures branch from dfac03a to 55e9ef7 Compare September 28, 2023 17:10
@hklarner hklarner requested a review from m4ra September 28, 2023 17:11
@m4ra m4ra merged commit 7265d2d into main Oct 2, 2023
2 checks passed
@m4ra m4ra deleted the hk-2023-09-refactors-debate-and-image-fixtures branch October 2, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra m4ra approved these changes

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hklarner @m4ra