Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8530 [mB] redesign support button - support button does not revert back to base color automatically after changing the state #5881

Open
sblindow opened this issue Dec 11, 2024 · 4 comments

Comments

@sblindow
Copy link
Contributor

URL:
Can be tested here

user:
All users

expected behaviour:
The support button changes color when hovered over or interacted with and changes back afterwards.

behaviour:
Currently the support button color stays 'highlighted' after interaction unless the user clicks elsewhere.

device & browser:
All devices and browsers

@sblindow sblindow changed the title #8530 [mB] redesign support button - support button color stays 'highlighted' after interaction unless the user clicks elsewhere #8530 [mB] redesign support button - support button does not revert back to base color automatically after changing the state Dec 11, 2024
@vellip
Copy link
Collaborator

vellip commented Dec 12, 2024

this is normal focus behavior
@hom3mad3 how do you handle these things usually?

@CarolingerSeilchenspringer
Copy link
Contributor

also ask @MarleyMi as she concepted the buttons

@MarleyMi
Copy link

MarleyMi commented Dec 16, 2024

Hey sorry about the late answer :O I didnt see this. @vellip
Behavior:
The color change is currently too slow. Clicking out makes it faster, but this is not optimal. Please insert a direct color change after user click.

User who clicks the button and wants to support:

  1. Button black
  2. User hovered: Button dark green
  3. User clicks button: should turn light green immediately (currently this is delayed): light green (should remain light green)

User who clicks button and no longer wants to support:

  1. Button light green
  2. User hovered: Button dark green
  3. User clicks button: Button directly black

I'm not sure if I've understood it correctly. But it should work the same way as here on Github. If I hover over the unsave button at the top right, it turns gray. When I click the unsave button, the / disappears directly from the button and the button changes to "Save" without the "/". That's exactly what I had in mind with the button from the behavior only with colors instead of the "/". The Like button on Youtube is similar they work with colors within the Icon that are changing.

@MarleyMi
Copy link

@vellip and me talked yesterday and decided that if it wasn't technically possible or too complicated, we would leave out the light green status and make the box darker as a hover effect like the other buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants