From 436f6f71e7c2c79e0fd5c3260852af9dd7c6db0c Mon Sep 17 00:00:00 2001 From: Philipp Veller Date: Tue, 19 Nov 2024 17:26:27 +0100 Subject: [PATCH] react/ratings: move icon overwrite out and into a4, change hover style --- changelog/8529.md | 6 ++++++ .../scss/components_user_facing/_rating.scss | 17 +++++------------ package.json | 2 +- requirements/base.txt | 2 +- 4 files changed, 13 insertions(+), 14 deletions(-) create mode 100644 changelog/8529.md diff --git a/changelog/8529.md b/changelog/8529.md new file mode 100644 index 0000000000..40aadd1955 --- /dev/null +++ b/changelog/8529.md @@ -0,0 +1,6 @@ +### Removed +- thumbs up/down icons in ratings because they are now in a4 + +### Added +- hover style for rating buttons +- active style for rating buttons diff --git a/meinberlin/assets/scss/components_user_facing/_rating.scss b/meinberlin/assets/scss/components_user_facing/_rating.scss index 9a8d50bee5..082d0633e0 100644 --- a/meinberlin/assets/scss/components_user_facing/_rating.scss +++ b/meinberlin/assets/scss/components_user_facing/_rating.scss @@ -9,7 +9,6 @@ .rating__label { word-break: normal; - margin-left: 0.4em; } .rating-button { @@ -18,22 +17,16 @@ padding: 0; i { - margin-right: 0.4em; - margin-bottom: 0.4em; display: inline; + font-weight: normal; } - &--active { + &--active, + &.is-selected { font-weight: bold; } - .fa-chevron-up:before { - content:"\f164"!important; // thumbs-up icon - font-weight: 400; - } - - .fa-chevron-down:before { - content:"\f165"!important; // thumbs-down icon - font-weight: 400; + &:hover { + text-decoration: underline; } } diff --git a/package.json b/package.json index 11fe05904b..4ac153d57a 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "@react-leaflet/core": "^2.1.0", "@turf/turf": "^6.5.0", "acorn": "8.12.0", - "adhocracy4": "liqd/adhocracy4#e10457d42e72d39d305c2579c5de5ce98f65be9c", + "adhocracy4": "liqd/adhocracy4#91852f59c54ac8ad5ee9cebeb66fa975c66f54d1", "autoprefixer": "10.4.19", "bootstrap": "5.2.3", "copy-webpack-plugin": "12.0.2", diff --git a/requirements/base.txt b/requirements/base.txt index d7641ee5c6..23994a9f58 100644 --- a/requirements/base.txt +++ b/requirements/base.txt @@ -1,5 +1,5 @@ # A4 -git+https://github.com/liqd/adhocracy4.git@e10457d42e72d39d305c2579c5de5ce98f65be9c#egg=adhocracy4 +git+https://github.com/liqd/adhocracy4.git@91852f59c54ac8ad5ee9cebeb66fa975c66f54d1#egg=adhocracy4 # Additional requirements beautifulsoup4==4.11.2