Skip to content

Commit

Permalink
Merge pull request Checkmarx#7159 from Checkmarx/deprecated_linting_m…
Browse files Browse the repository at this point in the history
…ethods

update(linting): update contribuition guide and remove deprecated linting methods
  • Loading branch information
ArturRibeiro-CX authored Jun 28, 2024
2 parents 9453cb9 + f3bf4c2 commit 82b7501
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
16 changes: 6 additions & 10 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ linters-settings:
- strings.SplitN

govet:
check-shadowing: true
shadow: true
settings:
printf:
funcs:
Expand All @@ -71,7 +71,6 @@ linters:
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
Expand All @@ -96,13 +95,11 @@ linters:
- noctx
- nolintlint
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- whitespace

# don't enable:
Expand All @@ -128,13 +125,12 @@ issues:
linters:
- gomnd
- scopelint

run:
timeout: 5m
tests: false
skip-dirs:
exclude-dirs:
- assets
- docs
- vendor
- pkg/parser/jsonfilter/parser
- pkg/parser/bicep/antlr
- pkg/parser/bicep/antlr
run:
timeout: 5m
tests: false
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Use succinct but descriptive name (prefix with *feature/issue#-descriptive-name>
5. Make your changes locally.
6. Validate your changes to reassure they meet project quality and contribution standards:
```sh
golint .
golangci-lint run
```
```sh
go mod vendor
Expand Down

0 comments on commit 82b7501

Please sign in to comment.