README: Replace RAW-HTML with image #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a discussion of this issue: github/markup#163 |
Correct. It seems it has been resolved for some images. One of the last comments points to a gist where it is still broken: github/markup#163 (comment) |
`.. raw::`-directives are not allowed on pypi. Let's just switch to using the image-directive to generate basically the same output. Signed-off-by: Chris Fiege <[email protected]>
jluebbe
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. raw::-directives are not allowed on pypi. Let's just switch to using the image-directive to generate basically the same output.I am aware that the
:align:directive does not work in the rendered file (at the moment). This seems to be a consequence of how Github handles external images: For images that are part of the repository:align:works, but pointing to something outside the repository doesn't.