From 5d5e7171642ac99edbd7b4f74ff4184ea32d4c0c Mon Sep 17 00:00:00 2001 From: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Date: Mon, 14 Aug 2023 14:59:40 -0400 Subject: [PATCH] Change go version to be `stable` in test CI; Remove `nolintlint` from CI (#357) --------- Co-authored-by: Ye Chen --- .github/workflows/test.yml | 2 +- .golangci.yml | 6 ++++++ pagination.go | 2 +- waitfor.go | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 48e2c476a..a216c4b49 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: '1.18' + go-version: 'stable' - run: go version - name: Run tidy run: make tidy diff --git a/.golangci.yml b/.golangci.yml index abdc2337b..955da7862 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -36,6 +36,12 @@ linters: - nosnakecase #################### + # conflicted with go fmt + - nolintlint + + # workaround to avoid linter failures of getting malformed json + - musttag + - bodyclose - contextcheck - nilerr diff --git a/pagination.go b/pagination.go index 0d5dff6bc..608985d60 100644 --- a/pagination.go +++ b/pagination.go @@ -23,7 +23,7 @@ type PageOptions struct { } // ListOptions are the pagination and filtering (TODO) parameters for endpoints -//nolint +// nolint type ListOptions struct { *PageOptions PageSize int `json:"page_size"` diff --git a/waitfor.go b/waitfor.go index 8485d50d6..649554b4f 100644 --- a/waitfor.go +++ b/waitfor.go @@ -275,7 +275,7 @@ func (client Client) WaitForLKEClusterConditions( // WaitForEventFinished waits for an entity action to reach the 'finished' state // before returning. It will timeout with an error after timeoutSeconds. // If the event indicates a failure both the failed event and the error will be returned. -//nolint +// nolint func (client Client) WaitForEventFinished( ctx context.Context, id any,