Change go version to be stable in test CI; Remove nolintlint from…

… CI (#357) --------- Co-authored-by: Ye Chen <[email protected]>
linode · Aug 14, 2023 · 5d5e717 · 5d5e717
1 parent fa0c718
commit 5d5e717
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v4
         with:
-          go-version: '1.18'
+          go-version: 'stable'
       - run: go version
       - name: Run tidy
         run: make tidy

diff --git a/.golangci.yml b/.golangci.yml
@@ -36,6 +36,12 @@ linters:
     - nosnakecase
     ####################
 
+    # conflicted with go fmt
+    - nolintlint
+
+    # workaround to avoid linter failures of getting malformed json
+    - musttag
+
     - bodyclose
     - contextcheck
     - nilerr

diff --git a/pagination.go b/pagination.go
@@ -23,7 +23,7 @@ type PageOptions struct {
 }
 
 // ListOptions are the pagination and filtering (TODO) parameters for endpoints
-//nolint
+// nolint
 type ListOptions struct {
 	*PageOptions
 	PageSize int    `json:"page_size"`

diff --git a/waitfor.go b/waitfor.go
@@ -275,7 +275,7 @@ func (client Client) WaitForLKEClusterConditions(
 // WaitForEventFinished waits for an entity action to reach the 'finished' state
 // before returning. It will timeout with an error after timeoutSeconds.
 // If the event indicates a failure both the failed event and the error will be returned.
-//nolint
+// nolint
 func (client Client) WaitForEventFinished(
 	ctx context.Context,
 	id any,