Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-route historical metrics #1737

Closed
grampelberg opened this issue Oct 3, 2018 · 4 comments · Fixed by #4155
Closed

Per-route historical metrics #1737

grampelberg opened this issue Oct 3, 2018 · 4 comments · Fixed by #4155

Comments

@grampelberg
Copy link
Contributor

Linkerd has metrics at the service level. These are valuable for understanding the general health of a service. Unfortunately, it is usually a specific route that is having problems. While it is possible to run top and get some metrics today, these are gathered in real time and not stored in prometheus.

It should be possible to see per-route metrics alongside the existing per-service metrics (success rate, latency, throughput). These can improve the time to fixing issues and provide visibility into what is really happening.

User Stories

  • As a service owner, I would like to see per-route metrics in my dashboards so that I can quickly see any endpoints that are operating outside my SLO.
  • As a service owner, I would like to see a list of all the routes in my service and sort that list by success rate, so that I can quickly see what is currently failing.
  • As a service owner, I would like to have per-route metrics aggregated by URL parameters such as user id, so that I can quickly see what code path is being taken.
  • As a service owner, I would like to persist per-route metrics so that I can use them to debug historical issues.

UX

CLI

GUI

Dashboards

Open Questions

@klingerf
Copy link
Contributor

klingerf commented Oct 3, 2018

Related to #187.

@grampelberg grampelberg added the priority/P0 Release Blocker label Oct 3, 2018
@grampelberg
Copy link
Contributor Author

Also related #1418

@ctaggart
Copy link

Any update on per-route metrics? Is it stubbed out in the UI and not implemented on the backend as of linkerd edge 18.11.2 as it appears here?

@grampelberg
Copy link
Contributor Author

@ctaggart it is on master (so it'll be in the next edge release). I believe most of the stuff you need is in 18.11.2 but the CLI pieces to actually see what is going on didn't land until earlier this week.

@grampelberg grampelberg removed this from the Hotspur milestone Nov 28, 2018
lundbird pushed a commit to lundbird/linkerd2 that referenced this issue Mar 9, 2020
lundbird pushed a commit to lundbird/linkerd2 that referenced this issue Mar 9, 2020
lundbird pushed a commit to lundbird/linkerd2 that referenced this issue Mar 9, 2020
alpeb pushed a commit that referenced this issue Mar 27, 2020
* Add route dashboard to grafana instance

Fixes #1737

Signed-off-by: alex lundberg <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants