-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ICC colors #806
Comments
Define "support". Aren't this should be done at the Also, I'm well aware of |
For now, it would just be ICC colors, not all CSS 4 colors. You are right, more advanced support would require implementing them on the But I just realized that we need support for |
Yes, the first step would be to parse CSS 4 colors, which a mix |
There is this crate which is seemingly basically a port of lcms and allows to convert colors from ICC profiles. Would you accept a PR that implements icc colors with that crate? Although I am somewhat worried about the fact that the crate has a lot of unsafe, perhaps we can put it behind an
icc
feature that is disabled by default and needs to be enabled explicitly? And we should put a warning that it's at one's "own risk", since the crate has a lot of unsafe. Since it's used in Firefox I do assume that they know what they were doing, but still.What do you think?
The text was updated successfully, but these errors were encountered: