Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ci: attempt to fix failing cross compile step #9347

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/actions/setup-go/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ inputs:
key-prefix:
description: "A prefix to use for the cache key, to separate cache entries from other workflows"
required: false
use-build-cache:
description: "Whether to use the build cache"
required: false
# Boolean values aren't supported in the workflow syntax, so we use a
# string. To not confuse the value with true/false, we use 'yes' and 'no'.
default: 'yes'

runs:
using: "composite"
Expand All @@ -17,7 +23,8 @@ runs:
with:
go-version: '${{ inputs.go-version }}'

- name: go cache
- name: go module and build cache
if: ${{ inputs.use-build-cache == 'yes' }}
uses: actions/cache@v3
with:
# In order:
Expand All @@ -35,6 +42,18 @@ runs:
${{ runner.os }}-go-${{ inputs.go-version }}-${{ inputs.key-prefix }}-${{ github.job }}-
${{ runner.os }}-go-${{ inputs.go-version }}-${{ inputs.key-prefix }}-

- name: go module cache
if: ${{ inputs.use-build-cache == 'no' }}
uses: actions/cache@v3
with:
# Just the module download cache.
path: |
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ inputs.go-version }}-${{ inputs.key-prefix }}-no-build-cache-${{ github.job }}-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-${{ inputs.go-version }}-${{ inputs.key-prefix }}-no-build-cache-${{ github.job }}-
${{ runner.os }}-go-${{ inputs.go-version }}-${{ inputs.key-prefix }}-no-build-cache-

- name: set GOPATH
shell: bash
run: |
Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,17 @@ jobs:
cross-compile:
name: cross compilation
runs-on: ubuntu-latest
strategy:
fail-fast: true
matrix:
# Please keep this list in sync with make/release_flags.mk!
include:
- name: i386
sys: freebsd-386 linux-386 windows-386
- name: amd64
sys: darwin-amd64 freebsd-amd64 linux-amd64 netbsd-amd64 openbsd-amd64 windows-amd64
- name: arm
sys: darwin-arm64 freebsd-arm linux-armv6 linux-armv7 linux-arm64 windows-arm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I like it this way better as it's more visible what is failing.

steps:
- name: git checkout
uses: actions/checkout@v3
Expand All @@ -148,9 +159,10 @@ jobs:
with:
go-version: '${{ env.GO_VERSION }}'
key-prefix: cross-compile
use-build-cache: 'no'

- name: build release for all architectures
run: make release
run: make release sys="${{ matrix.sys }}"

########################
# sample configuration check
Expand Down
1 change: 1 addition & 0 deletions make/release_flags.mk
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ DOCKER_RELEASE_HELPER = docker run \
-e SKIP_VERSION_CHECK \
lnd-release-helper

# Please keep this list in sync with .github/workflows/main.yml!
BUILD_SYSTEM = darwin-amd64 \
darwin-arm64 \
freebsd-386 \
Expand Down
Loading