build/ci: attempt to fix failing cross compile step #9347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull reviewers statsStats of the last 30 days for lnd:
|
guggero
force-pushed
the
cross-compile-fix
branch
2 times, most recently
from
6774c1d to
745371d
Compare
This is a tradeoff of disk space (and with that cache size) and compilation speed. Because we're still running into disk full errors with the full build cache, we remove it for the cross compile step. Which means we'll do more work each time.
This is just a test, perhaps this doesn't make any sense at all as it will clog up too many build runners.
guggero
force-pushed
the
cross-compile-fix
branch
from
745371d to
c022284
Compare
guggero
added
no-itest
no-changelog
golang/build system
bhandras
approved these changes
Dec 12, 2024
| - name: amd64 | ||
| sys: darwin-amd64 freebsd-amd64 linux-amd64 netbsd-amd64 openbsd-amd64 windows-amd64 | ||
| - name: arm | ||
| sys: darwin-arm64 freebsd-arm linux-armv6 linux-armv7 linux-arm64 windows-arm |
There was a problem hiding this comment.
Tbh I like it this way better as it's more visible what is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we fix the previously failing cross compilation CI step.
The step currently fails due to insufficient disk space available on the GitHub runners.
This is mainly due to the fact that we cache the whole Go module and build cache, which sums up for all the different architectures we build for.
This PR does two things: