Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[custom channels]: refactor AuxTrafficManager to be used for forwarding as well #9333

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[custom channels]: refactor AuxTrafficManager to be used for forwarding as well #9333

merged 3 commits into from
Dec 5, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Dec 4, 2024

Renames and moves the TlvTrafficShaper => AuxTrafficManager and prepares it to be used for forwarding bandwidth checks as well.

@guggero guggero added this to the v0.18.4 milestone Dec 4, 2024
@guggero guggero requested a review from Roasbeef December 4, 2024 14:52
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Dec 4, 2024
Merged
Merged
@guggero guggero force-pushed the aux-traffic-shaper-refactor branch from b187bbd to c088475 Compare December 4, 2024 16:37
GeorgeTsagk
GeorgeTsagk reviewed Dec 5, 2024
View reviewed changes
htlcswitch/interfaces.go Outdated Show resolved Hide resolved
htlcswitch/link.go Outdated Show resolved Hide resolved
@guggero
multi: move routing.TlvTrafficShaper => htlcswitch.AuxTrafficShaper
117c6bc 
With this commit we move the traffic shaper definition from the routing
package to the HTLC switch package as a preparation for being able to
use it there as well.
At the same time we rename it to AuxTrafficShaper to be more in line
with the other auxiliary components.
@guggero
htlcswitch: thread through packet's inbound wire records
a2e78c3 
For calculating the available auxiliary bandwidth of a channel, we need
access to the inbound custom wire records of the HTLC packet, which
might contain auxiliary information about the worth of the HTLC packet
apart from the BTC value being transported.
@guggero
multi: thread through and use AuxTrafficShaper
86b3be7
@guggero guggero force-pushed the aux-traffic-shaper-refactor branch from c088475 to 86b3be7 Compare December 5, 2024 11:39
Roasbeef
Roasbeef approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦆

@guggero guggero requested a review from GeorgeTsagk December 5, 2024 15:27
GeorgeTsagk
GeorgeTsagk approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥷

@Roasbeef Roasbeef merged commit 366e48b into lightningnetwork:master Dec 5, 2024
24 of 32 checks passed
@guggero guggero deleted the aux-traffic-shaper-refactor branch December 5, 2024 20:44
@guggero guggero mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@guggero guggero

Labels
custom chans htlcswitch no-changelog refactoring
Projects
None yet
Milestone
v0.18.4
Development

Successfully merging this pull request may close these issues.
4 participants
@guggero @Roasbeef @GeorgeTsagk @dstadulis