Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPS2: Fee Verification #61

Open
johncantrell97 opened this issue Dec 7, 2023 · 0 comments
Open

LSPS2: Fee Verification #61

johncantrell97 opened this issue Dec 7, 2023 · 0 comments
Labels

Comments

@johncantrell97
Copy link
Contributor

A wallet user should be verifying that the counterparty_skimmed_fee_msat is the agreed upon amount before claiming a payment from the LSP. This feels like something the library should be able to help them do. Something similar to htlc_intercepted where the end-user can pass the details of a PaymentClaimable event to the library and we respond with whether or not we think they should claim it.

We can't do this today because we don't generate the Invoice (or at a minimum the PaymentHash) that they should use. Maybe a simpler step to take is to use the channel manager and add a PaymentHash / PaymentSecret they should use in the invoice to InvoiceGenerationReady.

Depends on #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants