Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSPS2: Provide PaymentHash/PaymentSecret in InvoiceGenerationReady #60

Open
johncantrell97 opened this issue Dec 7, 2023 · 0 comments
Open

LSPS2: Provide PaymentHash/PaymentSecret in InvoiceGenerationReady #60

johncantrell97 opened this issue Dec 7, 2023 · 0 comments
Labels
LSPS2

Comments

@johncantrell97
Copy link
Contributor

johncantrell97 commented Dec 7, 2023 •
edited
Loading

We should probably generate and track the PaymentHash and PaymentSecret that the wallet user uses in the invoice. This enables the library to help with fee verification described in #61 .

We will need to set min_value_msat, invoice_expiry_delta_secs, and min_final_cltv_expiry_delta when creating the inbound payment for the user. I'm not sure if there are sensible defaults we should use? Could expose all three in the configuration for the wallet user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LSPS2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnull @johncantrell97