Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPS2: invalid client-side payment size handling #28

Open
johncantrell97 opened this issue Oct 25, 2023 · 1 comment
Open

LSPS2: invalid client-side payment size handling #28

johncantrell97 opened this issue Oct 25, 2023 · 1 comment
Labels

Comments

@johncantrell97
Copy link
Contributor

The client specifies the optional payment_size_msat at the start of the flow but we don't learn about the min_payment_size_msat and max_payment_size_msat the LSP supports until we receive the GetInfoResponse. We currently do not check if the provided payment size is within these bounds.

I'm not sure the best way to handle it though. I guess instead of surfacing the GetInfoResponse event to the end-user we would surface some kind of error event?

Thoughts?

@johncantrell97
Copy link
Contributor Author

Alternatively we could allow the client to continue and issue the buy request which would fail due to the LSP checking the bounds on the payment size.

@tnull tnull changed the title invalid client-side payment size handling LSPS2: invalid client-side payment size handling Oct 30, 2023
@tnull tnull added the LSPS2 label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants