-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: docstrings in the lightly/data subpackage #1741
Cleanup: docstrings in the lightly/data subpackage #1741
Conversation
seems like tests are failing due to issues not introduced via this pr... |
Hi, the tests fail because |
ooohh ok got it. fixed it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
+ Coverage 85.23% 85.31% +0.08%
==========================================
Files 162 162
Lines 6730 6729 -1
==========================================
+ Hits 5736 5741 +5
+ Misses 994 988 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@guarin do review the pr when u can, thanks :D |
Hi @ChiragAgg5k and thanks a lot for your contribution! Before I review, could you please remove the newly typed files from the list of files ignored by mypy here? Thank you! |
@philippmwirth hi there, the PR does not focus on |
I tried removing files which were formatted from the ignore, and it lead to some errors. i will push the fixes soon |
@philippmwirth any update? |
Did you not want to push the fixes first? |
@philippmwirth yup i do. but i am facing an issue here: the tests are failing due to an error in the code itself: |
Thanks, @ChiragAgg5k, I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ChiragAgg5k for your help! I quickly fixed the typing problem you encountered.
Clean up docstrings and typecheck _image.py, lightly_subset.py, and multi_view_collate.py
This PR will mark completing cleanup of
_image.py
,lightly_subset.py
andmulti_view_collage.py
files in the data subpackage according to issue #1689after this
_video.py
,collage.py
anddataset.py
files will be left, which will be done in separate PRs due to their long size.