Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to embedding scripts #1407

Merged
merged 11 commits into from
Sep 25, 2023

Conversation

agpeshal
Copy link
Contributor

@guarin
Copy link
Contributor

guarin commented Sep 25, 2023

This is awesome, thanks a lot for the PR!

I made some minor changes:

  • Replace calls to cast as it sometimes hides actual typing errors
  • Make sort_items_by_keys generic
  • Use torch.optim._LRScheduler instead of torch.optim.LRScheduler for backwards compatibility

@guarin guarin force-pushed the add-types-to-embedding-scripts branch from ee50c6b to 6e2d296 Compare September 25, 2023 07:41
@guarin guarin force-pushed the add-types-to-embedding-scripts branch from 6e2d296 to 51aab38 Compare September 25, 2023 07:43
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (f5a3b2e) 85.26% compared to head (90d293a) 85.29%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   85.26%   85.29%   +0.03%     
==========================================
  Files         130      130              
  Lines        5456     5469      +13     
==========================================
+ Hits         4652     4665      +13     
  Misses        804      804              
Files Changed Coverage Δ
lightly/embedding/_base.py 96.49% <100.00%> (+0.74%) ⬆️
lightly/embedding/callbacks.py 100.00% <100.00%> (ø)
lightly/embedding/embedding.py 100.00% <100.00%> (ø)
lightly/utils/reordering.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guarin guarin merged commit ae81278 into lightly-ai:master Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants