-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to embedding scripts #1407
Merged
guarin
merged 11 commits into
lightly-ai:master
from
agpeshal:add-types-to-embedding-scripts
Sep 25, 2023
Merged
Add types to embedding scripts #1407
guarin
merged 11 commits into
lightly-ai:master
from
agpeshal:add-types-to-embedding-scripts
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is awesome, thanks a lot for the PR! I made some minor changes:
|
guarin
force-pushed
the
add-types-to-embedding-scripts
branch
from
September 25, 2023 07:41
ee50c6b
to
6e2d296
Compare
guarin
force-pushed
the
add-types-to-embedding-scripts
branch
from
September 25, 2023 07:43
6e2d296
to
51aab38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
+ Coverage 85.26% 85.29% +0.03%
==========================================
Files 130 130
Lines 5456 5469 +13
==========================================
+ Hits 4652 4665 +13
Misses 804 804
☔ View full report in Codecov by Sentry. |
guarin
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1390