Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AmplitudeRescale transform #1658

Closed
Tracked by #1646
guarin opened this issue Oct 2, 2024 · 9 comments
Closed
Tracked by #1646

Add AmplitudeRescale transform #1658

guarin opened this issue Oct 2, 2024 · 9 comments

Comments

@guarin
Copy link
Contributor

guarin commented Oct 2, 2024

See #1646 for information

@guarin guarin changed the title Add AmplitudeRescale transform Add AmplitudeRescale transform Oct 2, 2024
@Aanchallllll
Copy link

Hello, I would like to work on the following transforms,
RandomFrequencyMask transform
PhaseShift transform
AmplitudeRescale transform
can i be assigned?

@guarin
Copy link
Contributor Author

guarin commented Oct 2, 2024

Hi yes of course, I'll already assign this one to you. I'll assign the other ones once the PR is ready.

@guarin
Copy link
Contributor Author

guarin commented Oct 8, 2024

Hi @Aanchallllll did you already have time to look into this?

@payo101
Copy link
Contributor

payo101 commented Oct 10, 2024

Hi @guarin could I try to work on this issue also?

@Prasadayus
Copy link

Hi @guarin can I work on this?

@guarin
Copy link
Contributor Author

guarin commented Oct 11, 2024

@payo101 I assigned the issue to you. @Prasadayus thanks for your interest, we only a assign a single person to an issue at once. Please have a look at our other open issues: good first issue

@payo101
Copy link
Contributor

payo101 commented Oct 12, 2024

@guarin Quick questions:

  • There are two hyperparameters for this transform m and n between which the value p gets decided. Now in the paper the values of m and n are given. So should we allow p as input, or m and n as inputs?
  • The input that we expect, is it FFT of the image or RFFT of the image?

@payo101
Copy link
Contributor

payo101 commented Oct 12, 2024

@guarin Also raised a PR for the issue: #1694
Please review and suggest changes, if any.

@guarin
Copy link
Contributor Author

guarin commented Oct 21, 2024

Completed in #1694

@guarin guarin closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants