Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDBMSProcessor to have configuration-driven database translator #42

Open
derek63 opened this issue Sep 15, 2014 · 4 comments
Open

Comments

@derek63
Copy link
Member

derek63 commented Sep 15, 2014

Right now it is hard-coded to ORACLE (which is fine because that is the only one we have so far).

Line 87: List inputStmt = Translator.ORACLE.translate(rdbmsContext);

We should make this configuration driven so the correct translator is selected at run-time.

@jewzaam
Copy link
Member

jewzaam commented Sep 15, 2014

Can get this from the datastore configuration, right?

@luan-cestari
Copy link
Collaborator

For me no problem to change it, but I think it is a bit pointless as there isnt any other implementation right now, but if you guys want I can change it

@jewzaam
Copy link
Member

jewzaam commented Sep 22, 2014

I can see something like MySQL/MariaDB coming along quickly (we have teams using them internally). We could leave this issue to be solved until then, but I feel it may be best to get it as a nice-to-have soon since it'll be clear what is supported by the configuration.

@jewzaam
Copy link
Member

jewzaam commented Dec 16, 2014

Moving this back into ready since it is not done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants