Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of failing requests that return > maxResultSize, return maxResultSize documents and warn #797

Open
alechenninger opened this issue Jun 21, 2017 · 3 comments

Comments

@alechenninger
Copy link
Contributor

No description provided.

@paterczm
Copy link
Contributor

I'm concerned this will lead to unpredictable results. I think it's safer to fail; that way we will see the problem quickly.

@alechenninger
Copy link
Contributor Author

Seeing the problem quickly doesn't need to be coupled to failing the request or not. We can log and alert for example. It changes whether customers are alerting us or we're doing it without them knowing.

Of course the "correctness" of the response suffers, but in the spirit of graceful degradation I think that may be preferable to failing in a potentially user facing way. It pushes the decision to the client to make that call. We'd be providing more options to deal with failure.

@alechenninger
Copy link
Contributor Author

@paterczm Even adding a limit on result size in bytes is technically a breaking change, just like lowering the result size in documents. Returning partial responses makes adding / changing these limits less likely to cause serious user facing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants