Remove lightblue-rest-integration-test as a dependency for lightblue-client

[jewzaam]

This is leading to dependency hell for releases. Client shouldn't require either of these! We're looking at releasing only 4.0.0 now and it is dependent on changes in rest at least...

[paterczm]

lightblue-rest is a dependency because it's used in integration testing (lightblue-client-integration-test). lightblue-client-integration-test used to be standalone, but at some point it was added to the client.

[paterczm]

And lightblue-core-hystrix dependency is used because client uses hystrix. Since we're considering to drop hystrix altogether, we can start by removing it from the client.

[paterczm]

@dcrissman, fyi.

[dcrissman]

com.redhat.lightblue.rest:lightblue-rest-integration-test makes LightblueClientTestHarness possible

lightblue-client-integration-test was added to the lightblue-client because it makes sense that the client would include tools for testing using the client.

As for hystrix, I have no objections to it being removed if we are removing hystrix anyway.

[jewzaam]

Re lightblue-client-integration-test, I'd recommend breaking into a
separate repo so we don't tie client to rest. We can incorporate it in the
lightblue repo as a submodule and have it built every time that is built
(nightly internally and when touched via travis).

Hystrix we had talked about breaking out. Thought we were considering
keeping it for client only. If so, hystrix could move to client?

On Wed, Mar 2, 2016 at 5:30 PM, Dennis Crissman [email protected]
wrote:

com.redhat.lightblue.rest:lightblue-rest-integration-test makes
LightblueClientTestHarness possible

lightblue-client-integration-test was added to the lightblue-client
because it makes sense that the client would include tools for testing
using the client.

As for hystrix, I have no objections to it being removed if we are
removing hystrix anyway.

—
Reply to this email directly or view it on GitHub
#267 (comment)
.

[dcrissman]

Re lightblue-client-integration-test, I'd recommend breaking into a separate repo so we don't tie client to rest. We can incorporate it in the lightblue repo as a submodule and have it built every time that is built (nightly internally and when touched via travis).

This change would also force us to move integration testing, or testing in the client that is based on the LightblueClientTestHarness, to this external project also.

What dependency hell were you running into? I assume you wanted to release an application using the new version of the client without releasing the rest layer, but I think that is somewhat problematic as well as it assumes there were no breaking changes in the rest layer.

[jewzaam]

Wanted to release the client without releasing core and rest. There isn't
a good reason in my mind to have these dependencies with a JSON based REST
interface. There's no code to share. Client doesn't need to even do
validation. If there's a change in rest then yes client needs rest to be
released, but that's not a build-time dependency.

On Wed, Mar 16, 2016 at 11:04 AM, Dennis Crissman [email protected]
wrote:

Re lightblue-client-integration-test, I'd recommend breaking into a
separate repo so we don't tie client to rest. We can incorporate it in the
lightblue repo as a submodule and have it built every time that is built
(nightly internally and when touched via travis).

This change would also force us to move integration testing, or testing in
the client that is based on the LightblueClientTestHarness, to this
external project also.

What dependency hell were you running into? I assume you wanted to release
an application using the new version of the client without releasing the
rest layer, but I think that is somewhat problematic as well as it assumes
there were no breaking changes in the rest layer.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#267 (comment)

[dcrissman]

In order to remove hystrix from lightblue-client, we would need to extract lightblue-core-hystrix into it's own library also. I am moving the hystrix element of this ticket to #273.

Another issue is that now we have removed jdk7 from core/mongo/rest and started using jdk8, the jdk7 build we had talked about continuing to support for the client is failing.

[dcrissman]

https://github.com/lightblue-platform/lightblue-test-utils was the former project name. I am thinking of re-using this repo, but I might rename it to lightblue-client-test. Objections? Suggestions?

[dcrissman]

Splitting the module will not fully solve the jdk7/8 problem. Any application running jdk7 and using the client-test module will be locked in at the last version built as only jdk8 builds can be made moving forward as it will depend on lightblue-rest.

[jewzaam]

The lightblue-rest dependency needs to be broken out and support 1.7 and
1.8 then, right?

On Thu, Mar 17, 2016 at 3:57 PM, Dennis Crissman [email protected]
wrote:

Splitting the module will not fully solve the jdk7/8 problem. Any
application running jdk7 and using the client-test module will be locked in
at the last version built as only jdk8 builds can be made moving forward as
it will depend on lightblue-rest.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#267 (comment)

[dcrissman]

That is a path we probably don't want to go down. As lightblue-rest-integration-test depends on lightblue-mongo-integration-test which depends on lightblue-core-integration-test which depends on LightblueFactory which puts us back to supporting both 7 and 8.

[jewzaam]

Then how is this going to be done? Don't the tests in client depend on
those integration tests?

On Thu, Mar 17, 2016 at 4:46 PM, Dennis Crissman [email protected]
wrote:

That is a path we probably don't want to go down. As
lightblue-rest-integration-test depends on lightblue-mongo-integration-test
which depends on lightblue-core-integration-test which depends on
LightblueFactory which puts us back to supporting both 7 and 8.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#267 (comment)

[dcrissman]

Not all the tests in lightblue-client, just the integration tests that are located at https://github.com/lightblue-platform/lightblue-client/tree/master/lightblue-client-integration-test/src/test/java/com/redhat/lightblue/client/integration/test

Tests in lightblue-client-core/http/hystrix do not have this dependency.

It will be awkward to have integration tests that live elsewhere, but if we want lightblue-client to support both jdk versions, then I don't see a way around it.

[dcrissman]

Discussion got cross-pollinated with #277

[jewzaam]

Core dependency removed with #277
Rest dependency remains.