Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle failed proposal execution #162

Open
fmorency opened this issue Dec 20, 2024 · 3 comments
Open

Handle failed proposal execution #162

fmorency opened this issue Dec 20, 2024 · 3 comments
Assignees
@chalabi2
Labels
bug Something isn't working

Comments

@fmorency
Copy link
Contributor

Failed execution of a proposal is not handled correctly. Per the Cosmos x/group documentation 1

On the other hand, a failed proposal execution will be marked as PROPOSAL_EXECUTOR_RESULT_FAILURE. Such a proposal can be re-executed multiple times, until it expires after MaxExecutionPeriod after voting period end.

E.g.
Proposal 88 execution failed but it's status is still marked as 'Execute'
2024-12-20_09-15

The status in the proposal modal is marked as 'Failed' which is good. However, the button is marked as 'Remove' which is wrong.

2024-12-20_09-19

And for some reason the modal layout is broken.
@fmorency fmorency added the bug Something isn't working label Dec 20, 2024
@chalabi2
Copy link
Collaborator

chalabi2 commented Dec 24, 2024 •
edited
Loading

modal layout is fixed in #167

@chalabi2
Copy link
Collaborator

Wouldnt re-executing a failed proposal just cause another failure in the execution?

@chalabi2
Copy link
Collaborator

Added failure status in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalabi2 chalabi2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmorency @chalabi2