Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of a hard copy of protobuf definition introduce a make target. #5

Open
ruseinov opened this issue Sep 8, 2020 · 1 comment

Comments

@ruseinov
Copy link
Member

ruseinov commented Sep 8, 2020

One that clones latest protobuf definitions from the original repo with the protocol.

The downside of this is that the protobuf definition will no longer be part of the repo, so the project won't build without successfully executing the aforementioned make target first.

@tylertreat what do you think?

Something along these lines was my plan:

rm -rf liftbridge-api
git clone --depth 1 [email protected]:liftbridge-io/liftbridge-api.git

plus a .gitignore for the liftbridge-api folder.

@tylertreat
Copy link
Member

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants