Navigate the puzzle with back and forward buttons #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some test failing because of the accessibility requirements, so I fixed it by putting them in a semantics container, which fixed it, but I have not seen this in the rest of the codebase. What is the recommended way to fix this? |
|
Closing it as not planned for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a request from discord to navigate the puzzles. It is possible to go back and see the previous moves, including the introductory move.
I am not entirely happy with the buttons, at the moment the navigating buttons do not have a tooltip while the show solution and the difficulty selector have it. I figured this is the best way though, as there is no translation for previous.