fix: maximise player when playing new video #6829
Conversation
Fixes a regression from 12be4c7, where upon trying to play a new video, the player would stay minimised. Additional, the playing video would be added to the queue, causing the previously played video to be played again. This is confusing to users, as it breaks the expectation of the player opening when trying to play a video.
That's hard to answer, it ultimately depends on the loading time if it's confusing to the user or not. If the next video loads within 300ms, that's probably quite intuitive, but for long loading times (or even API/network errors when loading the video info) it's likely not. |
|
Will be right back with an algorithm that can predict the future :) I think the issue right now is that the user clicks on a video and then undetermined amount of time later the action actually takes place, which just feels like the application is lagging. Having at least an indicator that app is doing some work in the background might help solve that. |
Sure, feel free to make a pull request if you got an idea how to do so (or show the loading indicator as you described previously) 👍 |
Fixes a regression from 12be4c7, whereupon trying to play a new video, the player would stay minimized. Additionally, the playing video would be added to the queue, causing the previously played video to be played again.
This is confusing to users, as it breaks the expectation of the player opening when trying to play a video.
Whilst, this causes the player to open, the previously video will continue to play, until the new one is loaded, which might also be unexpected. Maybe it should be paused during the loading time and the spinner be shown?