Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No padding below captions #6488

Open
3 tasks done
Philippe-Choquette opened this issue Sep 12, 2024 · 1 comment
Open
3 tasks done

No padding below captions #6488

Philippe-Choquette opened this issue Sep 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Philippe-Choquette
Copy link
Contributor

Steps to reproduce

Enable captions

Expected behavior

The standard implementation for captions is to have a small amount of padding below, usually of about 5% of the player's height

Actual behavior

There is currently no padding below the captions when rich rendering is disabled, and only a pixel or two when it's enabled, which is insufficient. This behaviour doesn't change with the use of system captions styling.


Rich rendering OFF / Portrait

Portrait


Rich rendering OFF / Landscape

Landscape


Rich rendering ON / Portrait

Portrait (with rich rendering)


Rich rendering ON / Landscape

Landscape (with rich rendering)

LibreTube version

0.25.2

Android version

Android 14

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Philippe-Choquette Philippe-Choquette added the bug Something isn't working label Sep 12, 2024
@Bnyro
Copy link
Member

Bnyro commented Sep 25, 2024

That depends on the format of the caption, see google/ExoPlayer#7934 (comment).

Reading that issue, I'm not very confident to do anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants