Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: Add images to CKEditor #7

Open
olli-suutari-jkl opened this issue Feb 28, 2019 · 1 comment
Open

Wishlist: Add images to CKEditor #7

olli-suutari-jkl opened this issue Feb 28, 2019 · 1 comment

Comments

@olli-suutari-jkl
Copy link

In Jyväskylä, we have been experimenting with images in descriptions, e.g.
https://www.jyvaskyla.fi/kirjasto/kirjastot?jyvaskylan-paakirjasto?lapset-ja-nuoret
https://www.jyvaskyla.fi/kirjasto/kirjastot?jyvaskylan-paakirjasto?lukupysakki

Images can currently be added to the CKEditor by copy-pasting them from somewhere else, this however is not very user friendly.

I think it would be great, if the CKEditor's image tool would be made available in Kirkanta.
https://ckeditor.com/docs/ckeditor4/latest/guide/dev_image.html

Uploading images to Kirkanta servers wouldn't be necessary since they could be uploaded to somewhere else and just linked to the editor.

@sjuvonen
Copy link
Contributor

sjuvonen commented Apr 8, 2019

There are security concerns if we were to allow linking to external images. Since the data is also used on Finna and Helmet.fi and also support for exporting to Suomi.fi is under progress, I think we should really avoid any "dumb" risks.

Remote content allows for example tracking users (and traffic to websites displaying those images) if not injecting viruses.

However, I think it would be possible to allow users to upload images to be used within the description text. Maybe the simplest solution would be to just make users upload photos in the Photos section and provide a mechanism to linking to those images "internally".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants