Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can create overlapping staff is present schedule rows #12

Open
olli-suutari-jkl opened this issue Jun 5, 2019 · 1 comment
Open

Comments

@olli-suutari-jkl
Copy link

Since the schedule rows are not validated for overlapping if multiple staff present rows are in succession, this may happen:
image

Here, 17-21 should obviously be self-service on Tuesday.

When saving, these silly schedules are updated to the database;
image

@sjuvonen
Copy link
Contributor

sjuvonen commented Jun 5, 2019

I'm phasing out my duties with Kirkanta so I'll just add my comment for further reference.
This problem can be split into two problems: user interface interaction and coherency of data on the API's side.

The first part I would not waste time with, but the consequence is that the API could report somewhat questionable schedules. But this is easy to fix by fixing the schedule definitions on the admin interface. That's why I would just not bother with additional validation or other checks.

In the API documentation it is mentioned that first and foremost librarians are responsible for the data per se and Kirjastot.fi is only a provider of the technical platform...

olli-suutari-jkl added a commit to olli-suutari-jkl/jyvaskyla.fi.kirjasto that referenced this issue Jun 5, 2019
- Fix schedule info from being larger than table
- Workaround for libraries-fi/kirkanta#12
- Removed scope from th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants