Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure user dial signals are respected #2842

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: ensure user dial signals are respected #2842

merged 1 commit into from
Nov 25, 2024

Conversation

achingbrain
Copy link
Member

Make sure we always respect the users' dial signal over the default dial timeout, even if it is longer than the default.

Previously the shortest timeout would win.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: ensure user dial signals are respected
a649f74 
Make sure we always respect the users' dial signal over the default
dial timeout, even if it is longer than the default.
@achingbrain achingbrain requested a review from a team as a code owner November 25, 2024 08:20
@achingbrain achingbrain merged commit bc90b4f into main Nov 25, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/respect-user-dial-signal branch November 25, 2024 09:00
@achingbrain achingbrain mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain