Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not require peer id for webrtc-direct #2820

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

achingbrain
Copy link
Member

We can get their peer id during the noise handshake, we do not need to have it in the multiaddr. We need it for regular webrtc as the SDP handshake happens via a relay, but that's not the case here.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

We can get their peer id during the noise handshake, we do not need
to have it in the multiaddr.  We need it for regular webrtc as the
SDP handshake happens via a relay, but that's not the case here.
@achingbrain achingbrain requested a review from a team as a code owner November 14, 2024 10:18
@achingbrain achingbrain merged commit 2feaedd into main Nov 14, 2024
34 checks passed
@achingbrain achingbrain deleted the fix/do-not-require-peerid-for-webrtc-direct branch November 14, 2024 16:39
@achingbrain achingbrain mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants