Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max modeMemory usage of modeMemoryPool_t::resize #748

Open
stgeke opened this issue Mar 25, 2024 · 1 comment
Open

Reduce max modeMemory usage of modeMemoryPool_t::resize #748

stgeke opened this issue Mar 25, 2024 · 1 comment
Assignees
Labels
feature Use this label to request a new feature! runtime Related to the OCCA runtime API
Milestone

Comments

@stgeke
Copy link
Contributor

stgeke commented Mar 25, 2024

The current implementation uses 'modeMemory' for both the new and old pool. While this method allows for fast data copying, it also results in high memory usage. This can be tricky in cases where we're running short on device memory. We might want to think about adding an option to stage it through to lower the maximum memory usage.

@kris-rowe kris-rowe added feature Use this label to request a new feature! runtime Related to the OCCA runtime API labels May 8, 2024
@kris-rowe kris-rowe added this to the v2.1 milestone May 8, 2024
@kris-rowe kris-rowe self-assigned this Jul 26, 2024
@kris-rowe
Copy link
Member

We will upstream an option to reallocate through host-memory from nekRS that addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Use this label to request a new feature! runtime Related to the OCCA runtime API
Projects
None yet
Development

No branches or pull requests

2 participants