Build as framework #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? I intend to include Swift code, which requires a dynamic framework, which afaik is not supported pre-iOS-8. I'm quite unclear on the details here: improvements welcome.
This file generated a libical error complaining
Can't parse as RECUR value in RRULE property. Removing entire property: FREQ=YEARLY\;UNTIL=123456T123456\;BYSETPOS=-1\,2\,-3\,4\,-5\,6\,-7\,8\,9\,10\,11\,12\,13\,14\,15\,16\,17\,18\,19\,20\,21\,22\,23\,4\,25\,26\,27\,28\,29\,30\,31\,32\,33\,34\,35\,36\,37\,38\,39\,40\,41\,42\,43\,44\,45\,46\,47\,48\,49\,50\,51\,52\,53\,54\;BYSECOND=1\,2\,3\,4\,5\,6\,7\,8\,9\,10\,11\,12\,13\,14\,15\,16\,17\,18\,19\,20\,21\,22\,23\,4\,25\,26
The error makes three of the tests for this file fail.
The issue appears to be that the UNTIL value is invalid; adding two more
digits (allowing it to be parsed as a YYYYMMDD string) fixes the error.
As far as I can tell this error is irrelevant for the affected tests.
tikitu
force-pushed
the
compile-to-framework-without-updating-libical
branch
from
86e0ef2 to
2ed5c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds XbICalendar as a framework. I took a lot of inspiration from @JosephDuffy's fork linked in #40, but I left the test and example targets in. They both build successfully, although I can't be sure the example project works as intended: I see a disturbing amount of error output, but I can't figure out if it's introduced by my changes or was already there.
The tests pass (for me), after fixing what seems to be a bad fixture file. I suspect this closes #41, since that's one of the tests that failed for me.
I'm not even close to 100% confident that I managed all the project/target/scheme-wrangling correctly, and I'm (of course) very happy to make any changes you might suggest.