app/admin/quests/create/page.tsx (1)

Line range hint 255-413: Standardize error handling across all task types

The error handling is inconsistent across different task types. Some use try-catch blocks while others don't, which could lead to uncaught errors and incomplete task creation.

1. Wrap each task creation in try-catch:

 } else if (step.type === "Quiz") {
+  try {
     if (
       step.data.quiz_name?.length === 0 ||
       // ... other validations
     ) {
       showNotification("Please fill all fields for Quiz", "info");
       continue;
     }
     const response = await AdminService.createQuiz({
       // ... quiz creation
     });
     if (response) {
       step.data.id = response.id;
     }
+  } catch (error) {
+    console.error("Error while creating quiz task:", error);
+    showNotification(`Error adding Quiz task: ${error}`, "error");
+  }
 }

2. Add JSON validation for Contract task:

 } else if (step.type === "Contract") {
   try {
+    let parsedCalls;
+    try {
+      parsedCalls = JSON.parse(step.data.contract_calls);
+    } catch (parseError) {
+      showNotification("Invalid JSON format in contract calls", "error");
+      continue;
+    }
     const response = await AdminService.createContract({
       quest_id: questId,
       name: step.data.contract_name,
       desc: step.data.contract_desc,
       href: step.data.contract_href,
       cta: step.data.contract_cta,
-      calls: JSON.parse(step.data.contract_calls),
+      calls: parsedCalls,
     });

app/admin/quests/create/page.tsx (1)

251-254: Good addition of task filtering to prevent duplicates!

The filtering of unsaved steps is an effective solution to prevent task duplication. However, consider removing or conditionally enabling the console.log statement before deployment.

-    console.log("Steps to save:", unsavedSteps);
+    if (process.env.NODE_ENV === 'development') {
+      console.log("Steps to save:", unsavedSteps);
+    }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

app/admin/quests/create/page.tsx (1)

258-419: Consider adding network failure recovery

The task creation process could be improved to handle network failures more gracefully:

1. Add retry logic for transient failures
2. Implement rollback for partially completed task groups
3. Save progress locally to allow recovery

Would you like me to provide a detailed implementation for any of these improvements?

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

app/admin/quests/create/page.tsx (1)

283-294: 🛠️ Refactor suggestion

Improve quiz questions error handling

The quiz questions creation silently catches errors for individual questions without proper error aggregation or user feedback.

As suggested in a previous review, implement error aggregation and user feedback:

+ let failedQuestions = [];
  for (const question of step.data.questions) {
    try {
      await AdminService.createQuizQuestion({
        quiz_id: response.quiz_id,
        question: question.question,
        options: question.options,
        correct_answers: question.correct_answers,
      });
    } catch (error) {
      console.error("Error executing promise:", error);
+     failedQuestions.push(question.question);
    }
  }
+ if (failedQuestions.length > 0) {
+   showNotification(
+     `Failed to create ${failedQuestions.length} questions. Please review and try again.`,
+     "warning"
+   );
+ }

app/admin/quests/create/page.tsx (1)

427-429: Consider partial success handling

The state is updated unconditionally after processing all steps, without considering partial failures.

Consider implementing a mechanism to track successful and failed tasks, and provide appropriate feedback to users:

+ const successfulSteps = [];
+ const failedSteps = [];
  for (const step of unsavedSteps) {
    try {
      // ... task creation logic ...
+     successfulSteps.push(step);
    } catch (error) {
+     failedSteps.push(step);
    }
  }
+ if (failedSteps.length > 0) {
+   showNotification(`${failedSteps.length} tasks failed to save. Please try again.`, "warning");
+ }
+ if (successfulSteps.length > 0) {
+   setSteps([...steps]);
+   setCurrentPage((prev) => prev + 1);
+ }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

app/admin/quests/create/page.tsx (2)

437-443: Optimize state updates

The state updates and page navigation could be more efficient.

Consider this optimization:

- setSteps([...steps]);
- setCurrentPage((prev) => prev + 1);
+ const updatedSteps = [...steps];
+ setSteps(updatedSteps);
+ setCurrentPage((prev) => prev + 1);

---

536-536: Remove unnecessary eslint disable comment

Instead of using an empty function with an eslint disable comment, consider using null or removing the prop if it's optional.

- // eslint-disable-next-line @typescript-eslint/no-empty-function
- setShowDomainPopup={() => {}}
+ setShowDomainPopup={null}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

+ let failedQuestions = [];
  for (const question of step.data.questions) {
    try {
      await AdminService.createQuizQuestion({
        quiz_id: response.quiz_id,
        question: question.question,
        options: question.options,
        correct_answers: question.correct_answers,
      });
    } catch (error) {
      console.error("Error executing promise:", error);
+     failedQuestions.push(question.question);
+     showNotification(`Failed to create question: ${error}`, "error");
    }
  }
+ if (failedQuestions.length > 0) {
+   throw new Error(`Failed to create ${failedQuestions.length} questions`);
+ }

app/admin/quests/create/page.tsx (5)

263-263: Clarify the log message
The console log "Steps to save:" provides useful debug info. Consider enhancing these logs with more context if needed for debugging.

---

280-311: Validate potential empty quiz questions array
You gracefully handle empty quiz field data but also consider if step.data.questions might be undefined or an empty array. Skipping iteration when questions are missing may avoid runtime errors.

---

312-330: Consistent notification style across tasks
The user notifications for missing fields in “TwitterFw” (lines 312-322) and other tasks vary slightly. For completeness, ensure all tasks maintain consistent messages in form and style.

---

395-408: Ensure coverage and thorough error reporting
You’ve wrapped “createBalance” in a try/catch, but the catch block logs the error and notifies only in the console. Consider using showNotification to elevate user awareness in case of failure, matching the other tasks.

---

549-549: Future-proof your domain popup
This no-op domain popup handler might be extended or removed if domain management is out of scope. Keeping it is fine, but consider clarifying it with a comment or removing unused code.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

#!/bin/bash
# Attempt to locate possible double increments or immediate re-calls of handleCreateTask
rg -A 3 "setCurrentPage"

#!/bin/bash
# Search for steps state and its usage
rg -A 5 "const \[steps, setSteps\]"

# Search for handleCreateTask function implementation
ast-grep --pattern 'const handleCreateTask = $_ => {
  $$$
}'

#!/bin/bash
# Search for the context around where setSteps and setCurrentPage are used together
rg -B 10 -A 10 "setSteps\(\[\.\.\.steps\]\);"

#!/bin/bash
# Searching for any references to isSaving besides lines 257-258, 454
rg "isSaving\.current"

#!/bin/bash
# Get more context around the isSaving.current usages
rg "isSaving\.current" -B 3 -A 3

#!/bin/bash
# Get the initialization of isSaving ref and any useEffect blocks
ast-grep --pattern 'const isSaving = useRef' -A 3
rg "useEffect.*\{.*isSaving" -A 5

#!/bin/bash
# Search for useRef initialization with more context
rg "const.*isSaving.*useRef" -B 2 -A 2
# Get a broader view of the file structure
rg "useRef|useEffect" app/admin/quests/create/page.tsx -B 1 -A 1

app/admin/quests/create/page.tsx (3)

32-32: Use a more descriptive comment for clarity.
The comment at line 257 is in Spanish (“Prevenir múltiples guardados”). Consider adding or switching to an English explanation of why and how we guard against multiple saves for consistency with the rest of the code.

---

262-265: Avoid leaving console.log statements in production code.
While it’s helpful for debugging, consider removing or converting this log to a user-facing notification in production to avoid cluttering logs.

- console.log("Steps to save:", unsavedSteps);
+ // console.debug("Steps to save:", unsavedSteps);

---

442-443: Separate state update from navigation for clarity.
Calling both setSteps([...steps]) and setCurrentPage(...) in rapid succession may cause potential confusion when debugging. Consider batching or sequentially clarifying these calls if more complexity is added later.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

app/admin/quests/create/page.tsx (1)

427-433: Optimize state updates and navigation

The state updates and navigation could be improved to prevent potential race conditions.

Consider this optimization:

- setSteps([...steps]); 
  
  } finally {
    isSaving.current = false;
    setButtonLoading(false);
-   setCurrentPage((prev) => prev + 1);
  }
+ 
+ // Move state updates and navigation outside finally block
+ setSteps([...steps]);
+ setCurrentPage((prev) => prev + 1);

This ensures that state updates and navigation occur only after all cleanup is complete.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

- calls: JSON.parse(step.data.contract_calls),
+ calls: (() => {
+   try {
+     return JSON.parse(step.data.contract_calls);
+   } catch (error) {
+     showNotification("Invalid contract calls format", "error");
+     throw error;
+   }
+ })(),

 } else if (step.type === "TwitterFw") {
+  try {
     if (
       step.data.twfw_name?.length === 0 ||
       step.data.twfw_desc?.length === 0 ||
       step.data.twfw_username?.length === 0
     ) {
       showNotification("Please fill all fields for Twitter Follow", "info");
       continue;
     }
     const response = await AdminService.createTwitterFw({
       quest_id: questId,
       name: step.data.twfw_name,
       desc: step.data.twfw_desc,
       username: step.data.twfw_username,
     });
     if (response) step.data.id = response.id;
+  } catch (error) {
+    console.error("Error while creating Twitter Follow task:", error);
+    showNotification(`Error adding Twitter Follow task: ${error}`, "error");
+  }
 }

+ let failedQuestions = [];
  for (const question of step.data.questions) {
    try {
      await AdminService.createQuizQuestion({
        quiz_id: response.quiz_id,
        question: question.question,
        options: question.options,
        correct_answers: question.correct_answers,
      });
    } catch (error) {
      console.error("Error executing promise:", error);
+     failedQuestions.push(question.question);
    }
  }
+ if (failedQuestions.length > 0) {
+   showNotification(
+     `Failed to create ${failedQuestions.length} questions. Please review and try again.`,
+     "warning"
+   );
+ }

app/admin/quests/create/page.tsx (2)

249-253: Guard against double-clicks by disabling the button earlier.

You already check isSaving.current to prevent multiple calls. Consider disabling the button as soon as the function is triggered and re-enabling it once completed – you have partially done so with setButtonLoading, but confirm that the button is effectively disabled at all times while isSaving.current is true.

---

307-447: Consolidate repeated logic for each step type creation.

Many task creations reuse a similar pattern: checking required fields, calling AdminService, and assigning step.data.id. Consolidating or standardizing this pattern (possibly via a factory or a single shared function receiving step.data) will reduce code duplication and maintenance overhead.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro