Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the hover animations for all cards #977

Closed
Kevils opened this issue Dec 3, 2024 · 22 comments · Fixed by #999
Closed

Standardize the hover animations for all cards #977

Kevils opened this issue Dec 3, 2024 · 22 comments · Fixed by #999
Assignees
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Dec 3, 2024

Description 📹

It would be necessary to standardize the hover animations for all the cards on Starknet Quest. I suggest using the hover effect from the glossary cards for all the other cards (DeFi cards, quests, collections, etc.), as it is smoother than the one that simply displays a border on the cards.

Glossary cards link : https://starknet.quest/discover/defi

https://www.loom.com/share/48bcdae44da94757b4ecfe873eca6197

Cards to modify :
Screenshot 2024-12-03 at 14 34 17
Screenshot 2024-12-03 at 14 35 07
Screenshot 2024-12-03 at 14 35 57

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack labels Dec 3, 2024
@OWK50GA
Copy link
Contributor

OWK50GA commented Dec 3, 2024

I can work on this

@michojekunle
Copy link
Contributor

Hello 👋,

I’d like to work on the issue to standardize hover animations across all cards on Starknet Quest.

My plan:

  • Analyze Current Animations: Compare hover effects on glossary cards and other cards (DeFi, quests, collections).
  • Implement Changes: Apply the glossary card hover effect to all cards for a consistent and smooth user experience.
  • Test Locally: Ensure functionality is intact and animations work uniformly.
  • Submit PR: Follow the repo’s workflow, including referencing the issue in the PR.

I’ll complete the task within the 3-day timeframe and ensure all guidelines are followed.

Looking forward to your approval to proceed!

@Pvsaint
Copy link
Contributor

Pvsaint commented Dec 5, 2024

Can I take this issues? I'm a frontend and smart contract developer and a first time contributor in this repo.
If assigned this issue, ETA 48 hours.

@Nityam573
Copy link

I’m interested in this one.

@emmanueldindu
Copy link

May I be assigned to this?

@PrathamJha1
Copy link

Can I attempt this issue?

@LuisChiej
Copy link

Can I start working on this?

@davedumto
Copy link

Hello my name is Dumto, I am a frontend developer, I am a new contributor to this project and I would love to work on this issue. Please can I be assigned?. ETA 1 Day

@Uyouyou
Copy link

Uyouyou commented Dec 9, 2024

Hi, can i be assigned to this task?

@Marchand-Nicolas
Copy link
Collaborator

Hello @emmanueldindu are you working on the issue ? Please keep me informed not to be unassigned

@KeneePatel
Copy link
Contributor

Hello Nico,

I would love to work on this. Have decent experience with Next and Typescript. Also have solved an issue here.

ETA: 1d
TG handle: @patelkenee

@emarc99
Copy link
Contributor

emarc99 commented Dec 19, 2024

Would love to do this. I have contributed to app/api.starknet.id projects in the past, so I have a pretty good understanding of your code base. I will ensure the aim of the task is precisely achieved. I have the necessary FE tech experience.
ETA - 3 days.

@Villarley
Copy link
Contributor

Villarley commented Dec 19, 2024

hi @Marchand-Nicolas @Kevils 🚀🚀🚀,
I’m Santiago Villarreal Arley, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon Buildathon for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.
I would tackle this issue by using the standard hover animation and adding it to the other by a sustainable solution, always using DRY and clean code.
Would love to contribute again to the project!
Pls feel free to reach out via telegram

@Birdmannn
Copy link

Hey Dev, can I work on this please?

@lauchaves
Copy link
Contributor

Hey 🙋🏻 may I work on this ? 🚀

@Emmanex01
Copy link
Contributor

May I solve the issue?
I'm a frontend developer, with 2+ years experience.

@omsant02
Copy link
Contributor

omsant02 commented Dec 19, 2024

Previously, i implemented the whole Essential defi concepts cards section in a previous pr,

i will implement that same smooth hover effect to all cards also

I would like to implement this hover effect, please assign this issue to me @Kevils @Marchand-Nicolas
ETA : 1 day

Thank you

@Snehagupta1907
Copy link
Contributor

can i take up this issue @Marchand-Nicolas

@A6dulmalik
Copy link

I'm a front-end developer and I’d love to work on this task.

@Marchand-Nicolas
Copy link
Collaborator

Hello @emarc99 is everything okay ? Please keep me informed not to get unassigned

@emarc99
Copy link
Contributor

emarc99 commented Dec 21, 2024

Yes, it's going quite ok. @Marchand-Nicolas
I will make a PR soon, today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.