Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback in diagrams #2259

Open
edwardalee opened this issue Apr 13, 2024 · 7 comments
Open

Feedback in diagrams #2259

edwardalee opened this issue Apr 13, 2024 · 7 comments
Assignees
Labels
bug Something isn't working diagrams Problems with diagram synthesis

Comments

@edwardalee
Copy link
Collaborator

The following minimal program illustrates two alignment problems with decorators put on connections:

image

On the feedback path, the decorator is put above the connection rather than on it, and on the feedforward path, the alignment is slightly off. The test case is here:

target Python
reactor Foo {
  input x
  output y
}
main reactor {
  f = new Foo()
  f2 = new Foo()
  f.y ~> f.x after 10ms
  f.y ~> f2.x
}
@edwardalee edwardalee added bug Something isn't working diagrams Problems with diagram synthesis labels Apr 13, 2024
@soerendomroes
Copy link
Collaborator

The slightly-off issue has been fixed in ELK 0.9.0. The self-loop issue appears to persist and is an issue in ELK.

@lhstrh
Copy link
Member

lhstrh commented Apr 27, 2024

@soerendomroes, is there anything actionable? Or is there maybe a GitHub issue that we can link to in ELK?

@lhstrh
Copy link
Member

lhstrh commented May 17, 2024

@soerendomroes and @a-sr, bumping this issue.

@soerendomroes
Copy link
Collaborator

See eclipse-elk/elk#1023

@lhstrh
Copy link
Member

lhstrh commented May 17, 2024

The issue says "This should have been fixed in 0.9.0" so does that mean the issue is fixed and we can close this? Or does it mean that a dependency needs to be bumped?

@lhstrh
Copy link
Member

lhstrh commented May 17, 2024

You also mentioned that "The self-loop issue appears to persist and is an issue in ELK." Is there an actual issue were this is tracked in ELK?

@soerendomroes
Copy link
Collaborator

@lhstrh The issue is tracked in eclipse-elk/elk#1023 in ELK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working diagrams Problems with diagram synthesis
Projects
None yet
Development

No branches or pull requests

4 participants