Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt tests to RESTARTING/PURGING (2nd part) #976

Closed
wants to merge 3 commits into from
Closed

adapt tests to RESTARTING/PURGING (2nd part) #976

wants to merge 3 commits into from

Conversation

christoph-zededa
Copy link
Contributor

@christoph-zededa christoph-zededa commented Jun 6, 2024 •
edited
Loading

refs #977

@christoph-zededa christoph-zededa changed the title tests: make ssh verbose [WIP - don't merge!!!] tests: make ssh verbose Jun 6, 2024
@christoph-zededa christoph-zededa force-pushed the ssh_verbose_output branch 8 times, most recently from 7f87a45 to e9ee410 Compare June 6, 2024 20:54
@christoph-zededa
pod: change PURGING state
1ceb801 
PURGING state does not exist anymore, use HALTING instead

Signed-off-by: Christoph Ostarek <[email protected]>
@christoph-zededa christoph-zededa changed the title [WIP - don't merge!!!] tests: make ssh verbose adapt tests to RESTARTING/PURGING (2nd part) Jun 6, 2024
@christoph-zededa
app_local_info: send PURGING/RESTARTING cmd
a8791ab 
but expect HALTING state

Signed-off-by: Christoph Ostarek <[email protected]>
@christoph-zededa
Copy link
Contributor Author

I see lots of:

2024-06-06T22:17:50.7496145Z       "severity": "err",
2024-06-06T22:17:50.7497162Z       "source": "dhcpcd",
2024-06-06T22:17:50.7497417Z       "iid": "2843",
2024-06-06T22:17:50.7497767Z       "content": "control_free: No such file or directory",
2024-06-06T22:17:50.7498128Z       "msgid": "1686",
2024-06-06T22:17:50.7498485Z       "timestamp": "2024-06-06T22:05:30.808785330Z"
2024-06-06T22:17:50.7498783Z     },

and

2024-06-06T22:17:50.7845035Z     {
2024-06-06T22:17:50.7845144Z       "severity": "err",
2024-06-06T22:17:50.7845264Z       "source": "dhcpcd",
2024-06-06T22:17:50.7845482Z       "iid": "2841",
2024-06-06T22:17:50.7845632Z       "content": "no such user dhcpcd",
2024-06-06T22:17:50.7845739Z       "msgid": "1626",
2024-06-06T22:17:50.7845949Z       "timestamp": "2024-06-06T22:05:30.673920100Z"
2024-06-06T22:17:50.7846117Z     },

@christoph-zededa christoph-zededa mentioned this pull request Jun 7, 2024
Closed
@milan-zededa
Copy link
Contributor

milan-zededa commented Jun 10, 2024 •
edited
Loading

@christoph-zededa You can ignore those dhcpcd errors. We always had those. I would like to get rid of them, but probably the only option is to filter them out inside the newlog service.

eriknordmark
eriknordmark approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

uncleDecart
uncleDecart reviewed Jun 17, 2024
View reviewed changes
.github/workflows/eden.yml Outdated
@@ -15,5 +15,5 @@ jobs:
name: Execute Eden test workflow
uses: ./.github/workflows/test.yml
with:
eve_image: "lfedge/eve:11.7.0"
eve_image: "lfedge/eve:12.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping version here means we should bump versions in default, and perhaps we should update and merge #969 before merging this, wdys @milan-zededa ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @christoph-zededa please update also default to 12.3.0.
Regarding #969, I'm debugging failing tests in #981. Once I'm done I will update 969 or maybe close it and open new PR with all test fixes. So do not get this PR delayed because of 969.

@christoph-zededa
github: test with newest EVE
db28fa0 
Signed-off-by: Christoph Ostarek <[email protected]>
milan-zededa
milan-zededa reviewed Jun 28, 2024
View reviewed changes
tests/eclient/testdata/app_local_info.txt
@@ -192,14 +192,18 @@ fi
DN="$1"
TIMESTAMP="${2:-0}"
CMD="${3:-COMMAND_UNSPECIFIED}"
EXPECTED_CMD="$CMD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes contained in this PR are already merged except for this modification in app_local_info.txt
However, the test passes so maybe it is not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok; then I just close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-zededa milan-zededa milan-zededa left review comments

@uncleDecart uncleDecart uncleDecart left review comments

@eriknordmark eriknordmark eriknordmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christoph-zededa @milan-zededa @eriknordmark @uncleDecart