Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of key-value rate limits #6947

Merged
merged 42 commits into from
Jul 21, 2023
Merged

Initial implementation of key-value rate limits #6947

merged 42 commits into from
Jul 21, 2023

Commits on Jun 15, 2023

  1. WIP

    @beautifulentropy
    beautifulentropy committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8e41eea View commit details
    Browse the repository at this point in the history

  2. Flesh out the RateLimit methods

    @beautifulentropy
    beautifulentropy committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    67ed1e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Store limit prefixes as integers

    @beautifulentropy
    beautifulentropy committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    759479f View commit details
    Browse the repository at this point in the history

  2. Improve errors.

    @beautifulentropy
    beautifulentropy committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    30e9b01 View commit details
    Browse the repository at this point in the history

  3. Add and test YAML loading

    @beautifulentropy
    beautifulentropy committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e834925 View commit details
    Browse the repository at this point in the history

  4. Refunds, Resets, and Initialization

    @beautifulentropy
    beautifulentropy committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5593b49 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Moar coverage and some small refactors.

    @beautifulentropy
    beautifulentropy committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    2d148b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Refunds should return full decisions

    @beautifulentropy
    beautifulentropy committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    32741c8 View commit details
    Browse the repository at this point in the history

  2. Initialization is hard.

    @beautifulentropy
    beautifulentropy committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d44d42c View commit details
    Browse the repository at this point in the history

  3. Another round of coverage improvements.

    @beautifulentropy
    beautifulentropy committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    529bfba View commit details
    Browse the repository at this point in the history

  4. Avoid shadowing and fix lints.

    @beautifulentropy
    beautifulentropy committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8178cf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Addressing comments and adding better checks for limit overrides

    @beautifulentropy
    beautifulentropy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a5a0d15 View commit details
    Browse the repository at this point in the history

  2. Typos

    @beautifulentropy
    beautifulentropy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    fb78d4d View commit details
    Browse the repository at this point in the history

  3. Add some cautionary panics inside of gcra

    @beautifulentropy
    beautifulentropy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5c8d04c View commit details
    Browse the repository at this point in the history

  4. Typos

    @beautifulentropy
    beautifulentropy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a2844b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Document enums to set stage for the last three id validators

    @beautifulentropy
    beautifulentropy committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    24673e4 View commit details
    Browse the repository at this point in the history

  2. Typo

    @beautifulentropy
    beautifulentropy committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b1c2f35 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Addressing comments (WIP)

    @beautifulentropy
    beautifulentropy committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    de93969 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Addressing comments.

    @beautifulentropy
    beautifulentropy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b2f9081 View commit details
    Browse the repository at this point in the history

  2. Lints.

    @beautifulentropy
    beautifulentropy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    3b1b762 View commit details
    Browse the repository at this point in the history

  3. We cannot support certain overrides

    @beautifulentropy
    beautifulentropy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1a09f68 View commit details
    Browse the repository at this point in the history

  4. Typo.

    @beautifulentropy
    beautifulentropy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    94ec876 View commit details
    Browse the repository at this point in the history

  5. Revert changes to policy.

    @beautifulentropy
    beautifulentropy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    95730f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Address limit.go comments.

    @beautifulentropy
    beautifulentropy committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    47622b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Changes to limit Names, validations, and tests.

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c413abf View commit details
    Browse the repository at this point in the history

  2. More test cases and a README

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    07699d4 View commit details
    Browse the repository at this point in the history

  3. Indent bullets

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1ac9b0e View commit details
    Browse the repository at this point in the history

  4. Small typos, etc.

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1e7a1ce View commit details
    Browse the repository at this point in the history

  5. Informated????

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1c0301e View commit details
    Browse the repository at this point in the history

  6. 🤦‍♀️

    @beautifulentropy
    beautifulentropy committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6ac0e5e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Addressing comments, two still outstanding.

    @beautifulentropy
    beautifulentropy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ea75b65 View commit details
    Browse the repository at this point in the history

  2. Addressed final comment.

    @beautifulentropy
    beautifulentropy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2f69601 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rate-limits-v2

    @beautifulentropy
    beautifulentropy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7442f18 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Update ratelimits/README.md 

    Co-authored-by: Phil Porada <[email protected]>
    @beautifulentropy @pgporada
    beautifulentropy and pgporada authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    603f187 View commit details
    Browse the repository at this point in the history

  2. Update ratelimits/README.md 

    Co-authored-by: Phil Porada <[email protected]>
    @beautifulentropy @pgporada
    beautifulentropy and pgporada authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c0289c5 View commit details
    Browse the repository at this point in the history

  3. Update ratelimits/README.md 

    Co-authored-by: Phil Porada <[email protected]>
    @beautifulentropy @pgporada
    beautifulentropy and pgporada authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    897f754 View commit details
    Browse the repository at this point in the history

  4. Update ratelimits/README.md 

    Co-authored-by: Phil Porada <[email protected]>
    @beautifulentropy @pgporada
    beautifulentropy and pgporada authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5ef087a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Address comemnts.

    @beautifulentropy
    beautifulentropy committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ca04728 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rate-limits-v2

    @beautifulentropy
    beautifulentropy committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d052e0c View commit details
    Browse the repository at this point in the history

  3. unnecessary conversion

    @beautifulentropy
    beautifulentropy committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9ec09f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Add fractional refund test.

    @beautifulentropy
    beautifulentropy committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    bb77c0b View commit details
    Browse the repository at this point in the history

  2. 🤦‍♀️

    @beautifulentropy
    beautifulentropy committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    861161f View commit details
    Browse the repository at this point in the history