Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cert-checker: Ignore incorrect PSL checks #3599

Closed
cpu opened this issue Mar 27, 2018 · 0 comments · Fixed by #3600
Closed

Cert-checker: Ignore incorrect PSL checks #3599

cpu opened this issue Mar 27, 2018 · 0 comments · Fixed by #3600

Comments

@cpu
Copy link
Contributor

cpu commented Mar 27, 2018

globalsign/certlint, used by cmd/cert-checker improperly flags certificates that have SANs equal to a private entry in the public suffix list as faulty, producing output like:

{u'fafe28b753a2e612d0221f85a1543af71a9c': {u'valid': False, u'problems': [u'Certificate CommonName "dev-myqnapcloud.com" equals "dev-myqnapcloud.com" from the public suffix list', u'Certificate subjectAltName "*.dev-myqnapcloud.com" equals "dev-myqnapcloud.com" from the public suffix list', u'Certificate subjectAltName "dev-myqnapcloud.com" equals "dev-myqnapcloud.com" from the public suffix list']}

See globalsign/certlint#17

Like OCSP Must Staple and the Subj. CN check we should ignore this error in cert-checker while the problem is addressed upstream:

// commonName has been deprecated for years, but common practice is still
// to include it for compatibility reasons. For instance, Chrome on macOS
// until very recently would error on an empty Subject (which is what we
// would have if we omitted CommonName). There have been proposals at
// CA/Browser Forum for an alternate contentless field whose purpose would
// just be to make Subject non-empty, but so far they have not been
// successful. If the check error is `certlintCNError`, ignore it.
if err.Error() == certlintCNError {
continue
}
// Certlint doesn't presently understand the RFC 7633 OCSP Must Staple
// extension. While this is unaddressed in the upstream library we ignore
// this error like we ignore `certlintCNError`.
if err.Error() == certlintOCSPMustStapleError {
continue
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants