Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue:4268) nested pseudo-selector parsing #4290

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

puckowski
Copy link
Contributor

What:

Fix for issue #4268.

Why:

Issue #4268 concerns valid CSS, see example CodePen: https://codepen.io/puckowski/pen/azooPzZ?editors=1111

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Lines of code delta: 38 added (including tests)

The following Less

a:is(.b, :is(.c)) {
  color: blue;
}

a:is(.b, :is(.c), :has(div)) {
  color: red;
}

becomes:

a:is(.b, :is(.c)) {
  color: blue;
}
a:is(.b, :is(.c), :has(div)) {
  color: red;
}

* Fix nested pseudo-selector parsing where selectors are separated by
  one or more commas.
@puckowski
Copy link
Contributor Author

I submitted a few PRs. I expect rebase(s) will be needed in order to merge all of them, so let me know when a rebase is needed.

@puckowski
Copy link
Contributor Author

Seems like this also resolves #4244

@puckowski
Copy link
Contributor Author

Seems like this also resolves #3802

@matthew-dean
Copy link
Member

@puckowski Looks great, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 7, 2024
@matthew-dean matthew-dean merged commit e4198ba into less:master Dec 7, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants