Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests in Dagger for brokers #188

Open
lerenn opened this issue Apr 7, 2024 · 4 comments
Open

Add tests in Dagger for brokers #188

lerenn opened this issue Apr 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@lerenn
Copy link
Owner

lerenn commented Apr 7, 2024

There is tests for brokers in extensions but there is no execution right now.

This should be added in Dagger.

@lerenn lerenn added the enhancement New feature or request label Apr 7, 2024
@lerenn lerenn assigned lerenn and unassigned lerenn Apr 7, 2024
@magraef
Copy link
Contributor

magraef commented Apr 11, 2024

Why do we run each test file using Dagger in a single container and create a map beforehand with selected tests? Wouldn't it be easier to just run all the tests at once using go test -v ./... to avoid future problems and issues like this?

@lerenn
Copy link
Owner Author

lerenn commented Apr 12, 2024

I have done that to be able to execute specific tests and not the whole set. I had in mind the fact that I could run the tests on different machines if they were too many of them.

But in the end, that was a silly idea, I prefer the go test -v ./... approach and we can still have another mechanism to execute a specific test.

@magraef
Copy link
Contributor

magraef commented Apr 12, 2024

Maybe we could add a optional parameter to the dagger test function to run a specific test and per default we can use ./...

@lerenn
Copy link
Owner Author

lerenn commented Apr 12, 2024

Yup, I think that's the best option !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants